Jakob Petsovits commented on merge request !476 at Plasma / PowerDevil
After awaiting the call, please check that the object is still alive with a QPointer. Probably makes sense to move out the call from the if condition into its own line plus subsequent aliveness check.
View ArticleJakob Petsovits approved merge request !476: applets/brightness: Check if...
Besides reacting to changes in the Solid.PowerManagement DBus service,we also need to track changes in the KeyboardBrightnessControl action(which translates into a specific DBus path) before trying to...
View ArticleIsmael Asensio pushed to project branch work/iasensio/check-supported-action...
Ismael Asensio(08990d19) at 08 Dec 11:30 applets/brightness: Check if KeyboardBrightness action is available ... and 3 more commits
View ArticleIsmael Asensio commented on merge request !476 at Plasma / PowerDevil
You are right. I've been able to reproduce the bug by shutting down the upower service and restarting powerdevil so it wakes up upower and it's easier to trigger the same race condition.This doesn't...
View ArticleFushan Wen approved merge request !475: daemon: Reduce unwanted brightness...
Extracted from MR !466 with minor tweaks in logic and commit message. Makes it possible for us to apply a dimming animation without getting the laptop screen's baseline brightness reset through...
View ArticleJakob Petsovits accepted merge request !475: daemon: Reduce unwanted...
Extracted from MR !466 with minor tweaks in logic and commit message. Makes it possible for us to apply a dimming animation without getting the laptop screen's baseline brightness reset through...
View ArticleIsmael Asensio commented on merge request !463 at Plasma / PowerDevil
at which point we might just as well go with a new MR altogether.Agreed, I just wanted to write down my thoughts, mostly as a note to my future self.About the proxymodel, I meant doing it in the C++...
View ArticleJakob Petsovits pushed to project branch...
Jakob Petsovits(59fb1e52) at 08 Dec 23:11 daemon: Introduce proper dimming API for ScreenBrightnessController ... and 13 more commits
View ArticleJakob Petsovits commented on merge request !466 at Plasma / PowerDevil
Both dependencies were merged, so I rebased and did some testing in order to get this out of draft status. Check MR description for the tests that I ran.The MR seems to work as intended on my system;...
View ArticleJakob Petsovits commented on merge request !360 at Plasma / PowerDevil
Ha, I forgot that there was already an open MR. I recently submitted !466 for a somewhat better implementation of a new dimming API. Closing this one in favor of !466.
View ArticleJakob Petsovits closed merge request !360: Draft: Introduce...
Builds on top of !361 and prior commits in the chain. Part of the ongoing effort of allowing per-display brightness controls ( #19). CC @zamundaaa, @nclariusCommit messagePrior to this commit,...
View ArticleScript Kiddy pushed to project branch master at Plasma / PowerDevil
Script Kiddy(36f1acf8) at 09 Dec 01:41 GIT_SILENT Sync po/docbooks with svn
View ArticleXaver Hugl commented on merge request !466 at Plasma / PowerDevil
I'm not sure if it's a good idea trying to fix the "multiple monitors with the same EDID" edge caseIt'll only affect Xorg, and there KScreen doesn't handle multiple displays with the same EDID...
View ArticleMatthieu Carteron opened merge request !477: Made KDocTools optional at...
To be more inline with other components, in which KDocTools is an optional dependency.
View ArticleSebastian Kügler pushed to project branch work/sebas/criticalhotplugbattery...
Sebastian Kügler(4de9e28c) at 11 Dec 11:30 silence warnings ... and 64 more commits
View ArticleJakob Petsovits approved merge request !477: Made KDocTools optional at...
To be more inline with other components, in which KDocTools is an optional dependency.
View ArticleJakob Petsovits commented on merge request !477 at Plasma / PowerDevil
Seems reasonable, thanks!
View ArticleJakob Petsovits accepted merge request !477: Made KDocTools optional at...
To be more inline with other components, in which KDocTools is an optional dependency.
View ArticleJakob Petsovits commented on merge request !471 at Plasma / PowerDevil
Ping @nicolasfella, @ltoscano - let's get this done before any merge conflicts surface?
View Article