Fabian Arndt accepted merge request !372: OSD: Close on focus lost at Plasma...
The OSD is closed when the active window is changed from the OSD to another window.This happens if the user clicks outside the OSD.This mimics the behaviour of modal dialogs.This also happens with...
View ArticleFabian Arndt deleted project branch work/cherry-pick-971630db at Plasma /...
Fabian Arndt(1eb6c81b) at 01 Jun 21:36
View ArticleXaver Hugl commented on merge request !342 at Plasma / PowerDevil
We could consider setting the brightness value immediately in setBrightness() and reverting it if the KAuth invocation fails. DDCutilDisplay is already doing this, and there may not be many downsides...
View ArticleJin Liu commented on merge request !368 at Plasma / PowerDevil
I'd expect both power / screen OSDs to work exactly the same as volume / brightness OSDs: doesn't take focus, doesn't accept mouse interaction, pressing the hotkey immediately activates the next...
View ArticleJakob Petsovits commented on merge request !373 at Plasma / PowerDevil
That's a very elegant way of handling these change notifications. Thanks and LGTM.
View ArticleJakob Petsovits approved merge request !373:...
By only modifying the kscreen output brightness before starting a SetConfigOperation,the only brightness change notifications will be from powerdevil setting the brightnesson the object, or from...
View ArticleJakob Petsovits commented on merge request !359 at Plasma / PowerDevil
Note to self: remove "to everyone" from this sentence, too.
View Articleivan tkachenko commented on merge request !368 at Plasma / PowerDevil
To be completely fair, pragma ComponentBehavior: Bound has nothing to do with context properties of the root context — it only affects repeaters, ListViews etc which would otherwise inject an...
View ArticleFabian Arndt commented on merge request !368 at Plasma / PowerDevil
I understand why a signal would be cleaner, sorry if I wasn't clear. It's not abstract at all.My question is about why to make the Osd a QML accessible type, not about the general architecture.
View Articleivan tkachenko pushed to project branch master at Plasma / PowerDevil
ivan tkachenko(d78ecf01) at 02 Jun 14:52 daemon: Don't disconnect from a null object
View Articleivan tkachenko accepted merge request !371: daemon: Don't disconnect from...
Regardless whether a Bluetooth device with a battery was disconnectedfrom within an operating system (e.g. by clicking Disconnect button inthe applet) or externally (such as falling asleep on its own,...
View Articleivan tkachenko deleted project branch work/ratijas/dangling-disconnect at...
ivan tkachenko(d78ecf01) at 02 Jun 14:52
View Articleivan tkachenko pushed to project branch Plasma/6.1 at Plasma / PowerDevil
ivan tkachenko(b73b7dc3) at 02 Jun 14:54 daemon: Don't disconnect from a null object
View Articleivan tkachenko commented on merge request !371 at Plasma / PowerDevil
Merged, and cherry-picked to branch Plasma/6.1 as b73b7dc3
View ArticleXaver Hugl accepted merge request !373: daemon/controllers/kwinbrightness:...
By only modifying the kscreen output brightness before starting a SetConfigOperation,the only brightness change notifications will be from powerdevil setting the brightnesson the object, or from...
View ArticleXaver Hugl commented on merge request !352 at Plasma / PowerDevil
And when you say the serial number is not unique, even if it's included, do you mean that's because the display can be connected through multiple connectors at the same time?Yes, that is a possibility,...
View ArticleJakob Petsovits commented on commit d69eea5c at Plasma / PowerDevil
Lambda is not an API, but it connects to a signal that's defined in the header and should match up function signatures. I wouldn't say that having const is required for making this function/lambda...
View ArticleXaver Hugl pushed new project branch work/zamundaaa/kwin-brightness-control...
Xaver Hugl(dff9d961) at 03 Jun 15:12 daemon/controllers/kwinbrightness: allow brightness control of scre...
View ArticleJakob Petsovits commented on merge request !368 at Plasma / PowerDevil
But.. I did a little research and learned that I can call Q_INVOKABLE functions from within QML. This does seem like a valid reason to me, or is it still preferable to use signals to call functions...
View Article