Kai Uwe Broulik commented on merge request !214 at Plasma / PowerDevil
Why is this needed ontop of the value: binding?
View ArticleJakob Petsovits commented on merge request !292 at Plasma / PowerDevil
If you move substantial amounts of code from another file, even if newly created, you need to use SPDX headers and copy the relevant existing copyright lines to the new file. Use SPDX format instead of...
View ArticleXaver Hugl accepted merge request !291: actions/bundled: replace for loop wit...
It's a bit shorter and nicer
View ArticleXaver Hugl deleted project branch work/zamundaaa/algorithm at Plasma / PowerD...
Xaver Hugl(a327480a) at 16 Dec 17:39
View ArticleJakob Petsovits opened merge request !293: kcmodule: Fix QML mistakes I made ...
Reported by @broulik (1, 2) in a post-merge review. Thanks!
View ArticleJakob Petsovits commented on merge request !214 at Plasma / PowerDevil
When the user inputs a new value, value gets reassigned and the binding is broken. Apparently this only happens for keyboard entry, whereas up/down arrows preserve the binding. Not sure what the deal...
View ArticleJakob Petsovits commented on issue #23 at Plasma / PowerDevil
Profile and global config modules were ported to QML (now merged into a single KCM with multiple pages). Activity power settings were moved to the Activities KCM by @nicolasfella. We're far enough into...
View ArticleJakob Petsovits closed issue #23: Port PowerDevil settings to KConfigXT, KCMs...
Three reasons I'm aware of:Using QML in all System Settings modules is good for consistency, e.g. we can use Kirigami FormLayouts.The profiles KCM in particular has atrocious UI and could benefit from...
View ArticleJakob Petsovits opened merge request !294: kcmodule: Add...
Addresses the last remaining suggestion of:BUG: 450275 (Merge Activity Power Settings into Activities KCM)The Energy Saving KCM could also contain a shortcut to it to improve discoverability even more.
View ArticleJakob Petsovits opened issue #32: Remove notion of "Advanced Power...
Follow-up to Bug 450276 which advised a merge of "Advanced Power Settings" into the main "Energy Saving" KCM, and that has happened for Plasma 6 so the bug was closed. But it also pointed out the...
View ArticleJakob Petsovits commented on merge request !107 at Plasma / PowerDevil
@olib, !259 (merged) is merged, please go ahead!
View ArticleOliver Beard commented on merge request !107 at Plasma / PowerDevil
Don't worry, it's on my TODOs. (I'll get around to it later this month - but if you'd like to do it sooner I can review!)
View ArticleKai Uwe Broulik commented on issue #32 at Plasma / PowerDevil
Perhaps we need to take a step back here and dismantle the “advanced options” and incorporate them into the main page entirely.The Low / Critical levels could also be incorporated into the relevant “On...
View ArticleScript Kiddy pushed to project branch master at Plasma / PowerDevil
Script Kiddy(d13378cd) at 17 Dec 02:07 SVN_SILENT made messages (.desktop file) - always resolve ours
View ArticleScript Kiddy pushed to project branch Plasma/5.27 at Plasma / PowerDevil
Script Kiddy(2f56dc6f) at 17 Dec 03:02 SVN_SILENT made messages (.desktop file) - always resolve ours
View ArticleJakob Petsovits commented on issue #32 at Plasma / PowerDevil
I agree that in principle, adding battery levels/limits to the main tabs, and adding a fourth tab for "On Critical Battery" would work conceptually. I'm worried about making the already tall tab...
View ArticleJakob Petsovits opened merge request !295: kcmodule: Internal naming tweaks a...
Adapt to the merge of profilesconfig and globalconfig KCMs,and remove "backend" terminology where it may be confusing.ProfileConfigKCM ->PowerKCMProfileConfigData...
View ArticleBogdan Onofriuchuk commented on merge request !292 at Plasma / PowerDevil
Thanks for your feedback. I will create a new merge request with three commits and will fix all the remarks. I will close this merge request for now.
View Article