Aleix Pol Gonzalez commented on merge request !510 at Plasma / PowerDevil
You are probably right. I'd say it's a fine rule to have to always pass const containers to for().
View ArticleJakob Petsovits commented on merge request !518 at Plasma / PowerDevil
LGTM, I guess, but do the org.freedesktop.Policy.Power and org.kde.ScreenBrightness services need similar changes?
View ArticleJakob Petsovits commented on merge request !510 at Plasma / PowerDevil
Done, also const-ified the other two getBatteries() for const-istency. Thanks for reviewing!
View ArticleClik here to view.
Jakob Petsovits approved merge request !514: kcm: Add Global Shortcuts...
Hehe. Makes it easier to go change some shortcut for e.g. suspendor shutdown when you're already in that settings menu anyway.
View ArticleJakob Petsovits commented on merge request !515 at Plasma / PowerDevil
How do you feel about "A" being already occupied by "Apply" System-Settings-wide?And, I hate to say it, but both "&B" and "&L" are in use already for the profile page (for "Change key&board...
View ArticleJakob Petsovits commented on merge request !517 at Plasma / PowerDevil
I would have done this if I had known it at the time. Great change. Thanks!
View ArticleJakob Petsovits approved merge request !517: kcm: Set buddyFor mnemonics at...
The default buddy is the item the Kirigami.FormData is attached to.When it's wrapped on a layout, set the buddy explicitly to thefirst/relevant control.Seems Qt doesnt’t set Qt::StrongFocus for...
View ArticleJakob Petsovits commented on merge request !516 at Plasma / PowerDevil
This seems like an excellent opportunity to switch to Qt::Literals::StringLiterals. Use u"..."_s please :)
View ArticleClik here to view.
Jakob Petsovits approved merge request !516: kcm: Add icons for power...
Makes the profile easily recognizable from battery monitor.Looks like we don’t have a non-battery icon for “balanced”:
View ArticleNate Graham commented on merge request !516 at Plasma / PowerDevil
We currently use speedometer for the balanced icon.Could definitely benefit from symlinking a better name for it in the icon theme though.
View ArticleClik here to view.
Nate Graham approved merge request !514: kcm: Add Global Shortcuts shortcut...
Hehe. Makes it easier to go change some shortcut for e.g. suspendor shutdown when you're already in that settings menu anyway.
View ArticleNate Graham approved merge request !517: kcm: Set buddyFor mnemonics at...
The default buddy is the item the Kirigami.FormData is attached to.When it's wrapped on a layout, set the buddy explicitly to thefirst/relevant control.Seems Qt doesnt’t set Qt::StrongFocus for...
View ArticleNate Graham approved merge request !507: applets/battery: Fix navigation...
When on the first item of the battery list, trying to force focusto the header item fails, probably because it is wrapped within aColumn.Just setting it to null works in this case, since it...
View ArticleIyán Méndez Veiga commented on merge request !509 at Plasma / PowerDevil
Happy to close this, now that there is a proper fix in the pipeline :)
View ArticleTracey Clark commented on merge request !512 at Plasma / PowerDevil
Tested this on my laptop which has a brightness slider for the keyboard backlightVerified that the slider was present right after building and after a restartExercising the brightness applet, I don't...
View ArticleIsmael Asensio pushed to project branch work/iasensio/applet-keyboard-up at...
Ismael Asensio(f7b5559a) at 10 Feb 20:28 applets/battery: Fix navigation keyboard cycle for the Up key ... and 4 more commits
View ArticleIsmael Asensio pushed to project branch master at Plasma / PowerDevil
Ismael Asensio(f7b5559a) at 10 Feb 20:31 applets/battery: Fix navigation keyboard cycle for the Up key
View ArticleIsmael Asensio accepted merge request !507: applets/battery: Fix navigation...
When on the first item of the battery list, trying to force focusto the header item fails, probably because it is wrapped within aColumn.Just setting it to null works in this case, since it...
View ArticleIsmael Asensio deleted project branch work/iasensio/applet-keyboard-up at...
Ismael Asensio(f7b5559a) at 10 Feb 20:32
View ArticleIsmael Asensio pushed new project branch work/cherry-pick-f7b5559a at Plasma...
Ismael Asensio(241b7b7d) at 10 Feb 20:34 applets/battery: Fix navigation keyboard cycle for the Up key ... and 23 more commits
View Article