Jakob Petsovits approved merge request !407: daemon/controllers: suppress...
If there should be an animation, KWin should do it directly, so that it matchesbetween brightness being applied in compositing vs. with powerdevil. There'salso situations in which we don't want the...
View ArticleMéven Car commented on merge request !396 at Plasma / PowerDevil
Approving your own PR shouldn't count.But given the code simplicity, a single approval would be fine IMO.
View ArticleJakob Petsovits commented on merge request !396 at Plasma / PowerDevil
Approving your own PR shouldn't count.It wasn't my PR, I just decided that enough time had passed to merge it (because @littlesweet doesn't have "Developer" status at the time of writing).
View ArticleJakob Petsovits pushed to project branch work/jpetso/cleanup-brightnesslogic...
Jakob Petsovits(d2f3a86c) at 22 Jul 09:07 daemon: Move brightness toggle logic into KeyboardBrightnessController ... and 55 more commits
View ArticleJakob Petsovits commented on merge request !389 at Plasma / PowerDevil
Rebased to resolve merge conflicts.
View ArticleMéven Car commented on merge request !387 at Plasma / PowerDevil
Shouldn't we remove the signal isBatteryConservationModeSupportedChanged as well then ?
View ArticleXaver Hugl approved merge request !389: daemon: Move brightness toggle logic...
The shared BrightnessLogic::BrightnessInfo struct had a membercalled valueBeforeTogglingOff, with some associated logic that'sonly used by its toggled() function.ScreenBrightnessController never wanted...
View ArticleJakob Petsovits pushed to project branch master at Plasma / PowerDevil
Jakob Petsovits(233e3252) at 23 Jul 07:11 daemon: Move brightness toggle logic into KeyboardBrightnessController
View ArticleJakob Petsovits accepted merge request !389: daemon: Move brightness toggle...
The shared BrightnessLogic::BrightnessInfo struct had a membercalled valueBeforeTogglingOff, with some associated logic that'sonly used by its toggled() function.ScreenBrightnessController never wanted...
View ArticleJakob Petsovits deleted project branch work/jpetso/cleanup-brightnesslogic at...
Jakob Petsovits(233e3252) at 23 Jul 07:11
View ArticleJakob Petsovits pushed to project branch...
Jakob Petsovits(8673fe97) at 24 Jul 10:03 kcmodule: Minor code clean-ups in ExternalServiceSettings ... and 58 more commits
View ArticleJakob Petsovits commented on merge request !387 at Plasma / PowerDevil
Good catch @meven, I looked into that but it's hooked up to the QML UI (via indirection) and marking it as CONST feels wrong. Instead, I added a proper setBatteryConservationModeSupported(bool) which...
View ArticleNate Graham approved merge request !410: applets/batterymonitor: Fix property...
Power profile holds by other applications should now be mentioned in the tool-tip instead of "System is in [Performance / Power Save] mode; scroll to change".Almost too minor to even backport, not sure...
View ArticleNate Graham commented on merge request !410 at Plasma / PowerDevil
Good catch. Backporting seems appropriate to me.
View ArticleJakob Petsovits pushed to project branch work/jpetso/hold-on at Plasma /...
Jakob Petsovits(c04880d1) at 03 Aug 06:34 applets/batterymonitor: Fix property names to show the right tool-t... ... and 1 more commit
View ArticleJakob Petsovits accepted merge request !410: applets/batterymonitor: Fix...
Power profile holds by other applications should now be mentioned in the tool-tip instead of "System is in [Performance / Power Save] mode; scroll to change".Almost too minor to even backport, not sure...
View ArticleJakob Petsovits deleted project branch work/jpetso/hold-on at Plasma /...
Jakob Petsovits(c04880d1) at 03 Aug 06:45
View ArticleJakob Petsovits commented on merge request !399 at Plasma / PowerDevil
Nice, that took care of my only concern then. Seems good to go unless you want to get a second opinion before merging.
View ArticleClik here to view.
Jakob Petsovits approved merge request !399: applets/batterymonitor: Show...
Currently we get complaints that the power profile icons sometimesreplace the battery icons, obscuring the battery level and chargingindicator.This commit makes use of some new Breeze icons added...
View ArticleJakob Petsovits pushed to project branch...
Jakob Petsovits(e24fa838) at 03 Aug 08:17 fixup autotests: adapt to ScreenBrightnessControl ... and 10 more commits
View Article