The interactive OSD implementation from MR !186 was a lot of work,but little discussion happened at the time about whether it shouldbe interactive at all.
Arguments have since been made that the low number of selectablepower profiles, and the non-destructive character of switchingbetween them, would make power profiles a better fit for immediatelyswitching profiles on shortcut presses with a non-interactive OSD.
This commit implements simple power profile cycling on Meta+B inthe PowerProfile action, and uses the Plasma OSD service'spre-existing "powerProfileChanged" method to display anon-interactive OSD popup once the profile was applied.
In turn, the entire interactive OSD service can be deletedfrom PowerDevil, reducing complexity. The corresponding globalshortcut definition moves from PowerDevilApp to the PowerProfileaction, similar to global shortcuts from other PowerDevil actions.(This makes PowerDevil shortcuts actually show up in the ShortcutsKCM as "Power Management" rather than the default app title fromKAboutData called "KDE Power Management System".)
CC various stakeholders:
- @nclarius, who was in fact the driving force between both the interactive OSD (MR !186) and the non-interactive OSD (plasma-workspace!3557).
- @root-core who contributed MRs !367, !368 and !369
- @justinzobel and @genericity of BUG: 469487 and BUG: 476921 respectively.
- @ngraham and @ratijas who participated in the relevant UX discussion within !368.