It is definitely better this way, sharing code instead of doing things manually, but I have to question the need for the separate mobile power management KCM to begin with, as opposed to making the desktop one with its full functionality fit nicely on mobile screens. I always have to manually bring up the desktop one on my PinePhone, because the mobile one does not support different settings for plugged-in or on-battery usage (and this MR does not change that, you read the settings only from the AC profile and then write them to all 3), and no, I do not want my PinePhone to suspend when it is plugged in, ever. (Not on idle, not even when I press the power button (that should just lock and turn off the screen), just never. Only the desktop KCM allows me to set that up.)
↧