Quantcast
Channel: PowerDevil activity
Viewing all articles
Browse latest Browse all 1724

Jakob Petsovits accepted merge request !478: daemon: Don't crash in PowerDevil::Core::unloadAllActiveActions() at Plasma / PowerDevil

$
0
0

Not sure why CI tests are failing, but I'll submit anyway, the finding is important enough and maybe someone has an idea how to fix CI.


Commit 584cfdf0 introduced the daemon's ability to remove actionsfrom Core::m_actionPool if they become unsupported at runtime.Commit 7a929fa0 fixed some resulting crashes by also cleaning uprelated map/set elements that contained this action.That was not enough, we got lots of crashes coming in since then.

The (many) remaining crashes happened in unloadAllActiveActions(),which cycles through Core::m_activeActions and accesses thecorresponding action pointer in m_actionPool. The implication isthat m_activeActions contains action IDs that are not presentin m_actionPool. And indeed, commit 7a929fa0 missed cleaning upthe action ID corresponding to the now-unsupported action.

With the dangling ID removed, PowerDevil should finally stop crashing.

SENTRY: FALLTHROUGH-30FBUG: 492349


Viewing all articles
Browse latest Browse all 1724

Trending Articles